Maxweight (supersedes #1467) #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not actually shorter, but is more obvious that all necessary parts are there
# Conflicts: # app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.java
peternewman
reviewed
Nov 9, 2019
app/src/main/java/de/westnordost/streetcomplete/quests/max_speed/AddMaxSpeedForm.kt
Show resolved
Hide resolved
rugk
reviewed
Nov 13, 2019
| @@ -623,7 +623,11 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards | |||
| <string name="quest_railway_crossing_barrier_none">It\'s not</string> | |||
| <string name="action_deselect_all">Deselect all</string> | |||
| <string name="quest_buildingType_retail_description">including buildings for restaurants, cafés, …</string> | |||
|
|
|||
| <string name="quest_maxweight_title">"What is the weight limit here?"</string> | |||
There was a problem hiding this comment.
Hmm, here is a quotation character too much, is not it? This should not be quoted…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't able to push on @matkoniecz branch, so I forked it